diff --git a/Socket.IO-Client-Swift.podspec b/Socket.IO-Client-Swift.podspec index 76aeb47..6924c40 100644 --- a/Socket.IO-Client-Swift.podspec +++ b/Socket.IO-Client-Swift.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "Socket.IO-Client-Swift" - s.version = "1.3.2" + s.version = "1.3.3" s.summary = "Socket.IO-client for Swift" s.description = <<-DESC Socket.IO-client for Swift. @@ -12,7 +12,7 @@ Pod::Spec.new do |s| s.author = { "Erik" => "nuclear.ace@gmail.com" } s.ios.deployment_target = '8.0' s.osx.deployment_target = '10.10' - s.source = { :git => "https://github.com/socketio/socket.io-client-swift.git", :tag => 'v1.3.2' } + s.source = { :git => "https://github.com/socketio/socket.io-client-swift.git", :tag => 'v1.3.3' } s.source_files = "SwiftIO/**/*.swift" s.requires_arc = true # s.dependency 'Starscream', '~> 0.9' # currently this repo includes Starscream swift files diff --git a/SwiftIO/SocketEngine.swift b/SwiftIO/SocketEngine.swift index 2fd9e2d..45a6dbe 100644 --- a/SwiftIO/SocketEngine.swift +++ b/SwiftIO/SocketEngine.swift @@ -30,7 +30,7 @@ extension String { } } -private typealias Probe = (msg:String, type:PacketType, data:[NSData]?) +private typealias Probe = (msg:String, type:PacketType, data:ContiguousArray?) private typealias ProbeWaitQueue = [Probe] public enum PacketType: String { @@ -476,10 +476,8 @@ public class SocketEngine: NSObject, WebSocketDelegate { } } - /* - Send a message with type 4 - */ - public func send(msg:String, withData datas:[NSData]?) { + /// Send an engine message (4) + public func send(msg:String, withData datas:ContiguousArray?) { if self.probing { self.probeWait.append((msg, PacketType.MESSAGE, datas)) } else { @@ -496,9 +494,8 @@ public class SocketEngine: NSObject, WebSocketDelegate { } private func sendPollMessage(var msg:String, withType type:PacketType, - datas:[NSData]? = nil) { + datas:ContiguousArray? = nil) { // println("Sending poll: \(msg) as type: \(type.rawValue)") - doubleEncodeUTF8(&msg) let strMsg = "\(type.rawValue)\(msg)" @@ -517,18 +514,19 @@ public class SocketEngine: NSObject, WebSocketDelegate { } } - private func sendWebSocketMessage(str:String, withType type:PacketType, datas:[NSData]? = nil) { - // println("Sending ws: \(str) as type: \(type.rawValue)") - self.ws?.writeString("\(type.rawValue)\(str)") + private func sendWebSocketMessage(str:String, withType type:PacketType, + datas:ContiguousArray? = nil) { + // println("Sending ws: \(str) as type: \(type.rawValue)") + self.ws?.writeString("\(type.rawValue)\(str)") - if datas != nil { - for data in datas! { - let (data, nilString) = self.createBinaryDataForSend(data) - if data != nil { - self.ws?.writeData(data!) + if datas != nil { + for data in datas! { + let (data, nilString) = self.createBinaryDataForSend(data) + if data != nil { + self.ws?.writeData(data!) + } } } - } } // Starts the ping timer @@ -554,7 +552,7 @@ public class SocketEngine: NSObject, WebSocketDelegate { } } - public func write(msg:String, withType type:PacketType, withData data:[NSData]?) { + public func write(msg:String, withType type:PacketType, withData data:ContiguousArray?) { dispatch_async(self.emitQueue) {[weak self] in if self == nil { return @@ -565,10 +563,10 @@ public class SocketEngine: NSObject, WebSocketDelegate { } if self!.websocket { - // NSLog("writing ws: \(msg):\(datas)") + // NSLog("writing ws: \(msg):\(data)") self?.sendWebSocketMessage(msg, withType: type, datas: data) } else { - // NSLog("writing poll: \(msg):\(datas)") + // NSLog("writing poll: \(msg):\(data)") self?.sendPollMessage(msg, withType: type, datas: data) } } diff --git a/SwiftIO/SocketEngineClient.swift b/SwiftIO/SocketEngineClient.swift index 8e984c7..81ac7ee 100644 --- a/SwiftIO/SocketEngineClient.swift +++ b/SwiftIO/SocketEngineClient.swift @@ -26,7 +26,6 @@ import Foundation @objc public protocol SocketEngineClient { - var ackQueue:dispatch_queue_attr_t! {get} var handleQueue:dispatch_queue_attr_t! {get} var emitQueue:dispatch_queue_attr_t! {get} var reconnecting:Bool {get} @@ -38,4 +37,4 @@ import Foundation func pollingDidFail(err:NSError) func webSocketDidCloseWithCode(code:Int, reason:String, wasClean:Bool) func webSocketDidFailWithError(error:NSError) -} +} \ No newline at end of file diff --git a/SwiftIO/SocketEventHandler.swift b/SwiftIO/SocketEventHandler.swift index 1922e02..82fd69b 100644 --- a/SwiftIO/SocketEventHandler.swift +++ b/SwiftIO/SocketEventHandler.swift @@ -28,10 +28,10 @@ public typealias NormalCallback = (NSArray?, AckEmitter?) -> Void public typealias AnyHandler = (event:String, items:AnyObject?) public typealias AckEmitter = (AnyObject...) -> Void -private func emitAckCallback(socket:SocketIOClient, num:Int, type:Int) +private func emitAckCallback(socket:SocketIOClient, num:Int) // Curried (items:AnyObject...) -> Void { - socket.emitAck(num, withData: items, withAckType: type) + socket.emitAck(num, withData: items) } class SocketEventHandler { @@ -46,7 +46,7 @@ class SocketEventHandler { func executeCallback(_ items:NSArray? = nil, withAck ack:Int? = nil, withAckType type:Int? = nil, withSocket socket:SocketIOClient? = nil) { dispatch_async(dispatch_get_main_queue()) {[weak self] in - self?.callback?(items, ack != nil ? emitAckCallback(socket!, ack!, type!) : nil) + self?.callback?(items, ack != nil ? emitAckCallback(socket!, ack!) : nil) return } } diff --git a/SwiftIO/SocketIOClient.swift b/SwiftIO/SocketIOClient.swift index 425d949..107131d 100644 --- a/SwiftIO/SocketIOClient.swift +++ b/SwiftIO/SocketIOClient.swift @@ -27,26 +27,24 @@ import Foundation public class SocketIOClient: NSObject, SocketEngineClient { let reconnectAttempts:Int! private lazy var params = [String: AnyObject]() - private var ackHandlers = [SocketAckHandler]() + private var ackHandlers = ContiguousArray() private var anyHandler:((AnyHandler) -> Void)? private var _closed = false private var _connected = false private var _connecting = false private var currentReconnectAttempt = 0 private var forcePolling = false - private var handlers = [SocketEventHandler]() + private var handlers = ContiguousArray() private var paramConnect = false private var _secure = false private var _sid:String? private var _reconnecting = false private var reconnectTimer:NSTimer? - internal var currentAck = -1 - internal var waitingData = [SocketPacket]() + var currentAck = -1 + var waitingData = ContiguousArray() public let socketURL:String - public let ackQueue = dispatch_queue_create("ackQueue".cStringUsingEncoding(NSUTF8StringEncoding), - DISPATCH_QUEUE_SERIAL) public let handleQueue = dispatch_queue_create("handleQueue".cStringUsingEncoding(NSUTF8StringEncoding), DISPATCH_QUEUE_SERIAL) public let emitQueue = dispatch_queue_create("emitQueue".cStringUsingEncoding(NSUTF8StringEncoding), @@ -62,7 +60,7 @@ public class SocketIOClient: NSObject, SocketEngineClient { } public var cookies:[NSHTTPCookie]? public var engine:SocketEngine? - public var nsp:String? + public var nsp = "/" public var reconnects = true public var reconnecting:Bool { return self._reconnecting @@ -244,69 +242,40 @@ public class SocketIOClient: NSObject, SocketEngineClient { } private func _emit(event:String, _ args:[AnyObject], ack:Int? = nil) { - var frame:SocketPacket - var str:String - - let (items, hasBinary, emitDatas) = SocketParser.parseEmitArgs(args) - if !self.connected { return } - if hasBinary { - if ack == nil { - str = SocketPacket.createMessageForEvent(event, withArgs: items, - hasBinary: true, withDatas: emitDatas.count, toNamespace: self.nsp) - } else { - str = SocketPacket.createMessageForEvent(event, withArgs: items, - hasBinary: true, withDatas: emitDatas.count, toNamespace: self.nsp, wantsAck: ack) - } - - self.engine?.send(str, withData: emitDatas) + let packet = SocketPacket(type: nil, data: args, nsp: self.nsp, id: ack) + var str:String + + SocketParser.parseForEmit(packet) + str = packet.createMessageForEvent(event) + + if packet.type == SocketPacketType.BINARY_EVENT { + self.engine?.send(str, withData: packet.binary) } else { - if ack == nil { - str = SocketPacket.createMessageForEvent(event, withArgs: items, hasBinary: false, - withDatas: 0, toNamespace: self.nsp) - } else { - str = SocketPacket.createMessageForEvent(event, withArgs: items, hasBinary: false, - withDatas: 0, toNamespace: self.nsp, wantsAck: ack) - } - self.engine?.send(str, withData: nil) } } // If the server wants to know that the client received data - func emitAck(ack:Int, withData data:[AnyObject]?, withAckType ackType:Int) { - dispatch_async(self.ackQueue) {[weak self] in - if self == nil || !self!.connected || data == nil { + func emitAck(ack:Int, withData args:[AnyObject]) { + dispatch_async(self.emitQueue) {[weak self] in + if self == nil || !self!.connected { return } - // println("sending ack: \(ack) \(data)") - let (items, hasBinary, emitDatas) = SocketParser.parseEmitArgs(data!) + let packet = SocketPacket(type: nil, data: args, nsp: self!.nsp, id: ack) var str:String - if !hasBinary { - if self?.nsp == nil { - str = SocketPacket.createAck(ack, withArgs: items, - withAckType: 3, withNsp: "/") - } else { - str = SocketPacket.createAck(ack, withArgs: items, - withAckType: 3, withNsp: self!.nsp!) - } - - self?.engine?.send(str, withData: nil) + SocketParser.parseForEmit(packet) + str = packet.createAck() + + if packet.type == SocketPacketType.BINARY_ACK { + self?.engine?.send(str, withData: packet.binary) } else { - if self?.nsp == nil { - str = SocketPacket.createAck(ack, withArgs: items, - withAckType: 6, withNsp: "/", withBinary: emitDatas.count) - } else { - str = SocketPacket.createAck(ack, withArgs: items, - withAckType: 6, withNsp: self!.nsp!, withBinary: emitDatas.count) - } - - self?.engine?.send(str, withData: emitDatas) + self?.engine?.send(str, withData: nil) } } } @@ -361,8 +330,8 @@ public class SocketIOClient: NSObject, SocketEngineClient { // Should be removed and moved to SocketEngine func joinNamespace() { - if self.nsp != nil { - self.engine?.send("0/\(self.nsp!)", withData: nil) + if self.nsp != "/" { + self.engine?.send("0/\(self.nsp)", withData: nil) } } diff --git a/SwiftIO/SocketPacket.swift b/SwiftIO/SocketPacket.swift index cfcbad6..3d981cc 100644 --- a/SwiftIO/SocketPacket.swift +++ b/SwiftIO/SocketPacket.swift @@ -43,16 +43,16 @@ enum SocketPacketType: Int { } class SocketPacket { - let type:SocketPacketType - var binary = [NSData]() + var binary = ContiguousArray() var currentPlace = 0 var data:[AnyObject]? var id:Int? var justAck = false var nsp = "" var placeholders:Int? + var type:SocketPacketType? - init(type:SocketPacketType, data:[AnyObject]? = nil, nsp:String = "", + init(type:SocketPacketType?, data:[AnyObject]? = nil, nsp:String = "", placeholders:Int? = nil, id:Int? = nil) { self.type = type self.data = data @@ -61,12 +61,6 @@ class SocketPacket { self.id = id } - /// Only call if you know data is not nil - func createBinaryPlaceHolders() { - var strData = "\(self.data!)" - println(strData) - } - func getEvent() -> String { return data?.removeAtIndex(0) as! String } @@ -95,77 +89,77 @@ class SocketPacket { } } - class func createMessageForEvent(event:String, withArgs args:[AnyObject], - hasBinary:Bool, withDatas datas:Int = 0, toNamespace nsp:String?, wantsAck ack:Int? = nil) -> String { - + func createMessageForEvent(event:String) -> String { var message:String var jsonSendError:NSError? - if !hasBinary { - if nsp == nil { - if ack == nil { + if self.binary.count == 0 { + self.type = SocketPacketType.EVENT + + if self.nsp == "/" { + if self.id == nil { message = "2[\"\(event)\"" } else { - message = "2\(ack!)[\"\(event)\"" + message = "2\(self.id!)[\"\(event)\"" } } else { - if ack == nil { - message = "2/\(nsp!),[\"\(event)\"" + if self.id == nil { + message = "2/\(self.nsp),[\"\(event)\"" } else { - message = "2/\(nsp!),\(ack!)[\"\(event)\"" + message = "2/\(self.nsp),\(self.id!)[\"\(event)\"" } } } else { - if nsp == nil { - if ack == nil { - message = "5\(datas)-[\"\(event)\"" + self.type = SocketPacketType.BINARY_EVENT + + if self.nsp == "/" { + if self.id == nil { + message = "5\(self.binary.count)-[\"\(event)\"" } else { - message = "5\(datas)-\(ack!)[\"\(event)\"" + message = "5\(self.binary.count)-\(self.id!)[\"\(event)\"" } } else { - if ack == nil { - message = "5\(datas)-/\(nsp!),[\"\(event)\"" + if self.id == nil { + message = "5\(self.binary.count)-/\(self.nsp),[\"\(event)\"" } else { - message = "5\(datas)-/\(nsp!),\(ack!)[\"\(event)\"" + message = "5\(self.binary.count)-/\(self.nsp),\(self.id!)[\"\(event)\"" } } } - return self.completeMessage(message, args: args) + return self.completeMessage(message) } - class func createAck(ack:Int, withArgs args:[AnyObject], withAckType ackType:Int, - withNsp nsp:String, withBinary binary:Int = 0) -> String { + func createAck() -> String { var msg:String - if ackType == 3 { + if self.binary.count == 0 { if nsp == "/" { - msg = "3\(ack)[" + msg = "3\(self.id!)[" } else { - msg = "3/\(nsp),\(ack)[" + msg = "3/\(self.nsp),\(self.id!)[" } } else { if nsp == "/" { - msg = "6\(binary)-\(ack)[" + msg = "6\(self.binary.count)-\(self.id!)[" } else { - msg = "6\(binary)-/\(nsp),\(ack)[" + msg = "6\(self.binary.count)-/\(self.nsp),\(self.id!)[" } } - return self.completeMessage(msg, args: args, ack: true) + return self.completeMessage(msg, ack: true) } - private class func completeMessage(var message:String, args:[AnyObject], ack:Bool = false) -> String { + func completeMessage(var message:String, ack:Bool = false) -> String { var err:NSError? - if args.count == 0 { + if self.data == nil || self.data!.count == 0 { return message + "]" } else if !ack { message += "," } - for arg in args { - + for arg in self.data! { if arg is NSDictionary || arg is [AnyObject] { let jsonSend = NSJSONSerialization.dataWithJSONObject(arg, options: NSJSONWritingOptions(0), error: &err) diff --git a/SwiftIO/SocketParser.swift b/SwiftIO/SocketParser.swift index 20fbe9e..3b68e51 100644 --- a/SwiftIO/SocketParser.swift +++ b/SwiftIO/SocketParser.swift @@ -22,59 +22,114 @@ import Foundation +private let shredder = SocketParser.PacketShredder() + class SocketParser { + // Translation of socket.io-parser#deconstructPacket + private class PacketShredder { + var buf = ContiguousArray() + + func shred(data:AnyObject) -> AnyObject { + if let bin = data as? NSData { + let placeholder = ["_placeholder" :true, "num": buf.count] + + buf.append(bin) + + return placeholder + } else if let arr = data as? NSArray { + var newArr = NSMutableArray(array: arr) + + for i in 0.. SocketPacket? { let arr = Array(str) let type = String(arr[0]) - + if arr.count == 1 { return SocketPacket(type: SocketPacketType(str: type)) } - + var id = nil as Int? var nsp = "" var i = 0 var placeholders = -1 - + if type == "5" || type == "6" { var buf = "" - + while arr[++i] != "-" { buf += String(arr[i]) if i == arr.count { break } } - + if buf.toInt() == nil || arr[i] != "-" { - println(buf) NSLog("Error parsing \(str)") return nil } else { placeholders = buf.toInt()! } } - + if arr[i + 1] == "/" { while ++i < arr.count { let c = arr[i] - + if c == "," { break } - + nsp += String(c) } } - + if i + 1 >= arr.count { return SocketPacket(type: SocketPacketType(str: type), nsp: nsp, placeholders: placeholders, id: id) } - + let next = String(arr[i + 1]) - + if next.toInt() != nil { var c = "" while ++i < arr.count { @@ -85,226 +140,87 @@ class SocketParser { break } } - + id = c.toInt() } - + if i + 1 < arr.count { let d = String(arr[++i...arr.count-1]) let noPlaceholders = d["(\\{\"_placeholder\":true,\"num\":(\\d*)\\})"] ~= "\"~~$2\"" - + let data = SocketParser.parseData(noPlaceholders) as! [AnyObject] - + return SocketPacket(type: SocketPacketType(str: type), data: data, nsp: nsp, placeholders: placeholders, id: id) } - + return nil } - - // Parse an NSArray looking for binary data - class func parseArray(arr:NSArray, var currentPlaceholder:Int) -> (NSArray, Bool, [NSData]) { - var replacementArr = [AnyObject](count: arr.count, repeatedValue: 1) - var hasBinary = false - var arrayDatas = [NSData]() - - for g in 0.. AnyObject? { var err:NSError? let stringData = data.dataUsingEncoding(NSUTF8StringEncoding, allowLossyConversion: false) let parsed:AnyObject? = NSJSONSerialization.JSONObjectWithData(stringData!, options: NSJSONReadingOptions.AllowFragments, error: &err) - + if err != nil { // println(err) return nil } - + return parsed } - - class func parseEmitArgs(args:[AnyObject]) -> ([AnyObject], Bool, [NSData]) { - var items = [AnyObject](count: args.count, repeatedValue: 1) - var currentPlaceholder = -1 - var hasBinary = false - var emitDatas = [NSData]() - - for i in 0.. (NSDictionary, Bool, [NSData]) { - var returnDict = NSMutableDictionary() - var hasBinary = false - var returnDatas = [NSData]() - - for (key, value) in dict { - if let binaryData = value as? NSData { - currentPlaceholder++ - hasBinary = true - returnDatas.append(binaryData) - returnDict[key as! String] = ["_placeholder": true, "num": currentPlaceholder] - } else if let arr = value as? NSArray { - let (replace, hadBinary, arrDatas) = self.parseArray(arr, currentPlaceholder: currentPlaceholder) - - if hadBinary { - hasBinary = true - returnDict[key as! String] = replace - currentPlaceholder += arrDatas.count - returnDatas.extend(arrDatas) - } else { - returnDict[key as! String] = arr - } - } else if let dict = value as? NSDictionary { - // Recursive - let (nestDict, hadBinary, nestDatas) = self.parseNSDictionary(dict, currentPlaceholder: currentPlaceholder) - - if hadBinary { - hasBinary = true - returnDict[key as! String] = nestDict - currentPlaceholder += nestDatas.count - returnDatas.extend(nestDatas) - } else { - returnDict[key as! String] = dict - } - } else { - returnDict[key as! String] = value - } - } - - return (returnDict, hasBinary, returnDatas) - } - + // Parses messages recieved - class func parseSocketMessage(var stringMessage:String, socket:SocketIOClient) { + class func parseSocketMessage(stringMessage:String, socket:SocketIOClient) { if stringMessage == "" { return } - + func checkNSP(nsp:String) -> Bool { - if nsp == "" && socket.nsp != nil { + if nsp == "" && socket.nsp != "/" { return true } else { return false } } - - var p = parseString(stringMessage) as SocketPacket! - - + + let p = parseString(stringMessage) as SocketPacket! + if p.type == SocketPacketType.EVENT { if checkNSP(p.nsp) { return } - + socket.handleEvent(p.getEvent(), data: p.data, isInternalMessage: false, wantsAck: p.id, withAckType: 3) } else if p.type == SocketPacketType.ACK { if checkNSP(p.nsp) { return } - + socket.handleAck(p.id!, data: p.data) } else if p.type == SocketPacketType.BINARY_EVENT { if checkNSP(p.nsp) { return } - + socket.waitingData.append(p) } else if p.type == SocketPacketType.BINARY_ACK { if checkNSP(p.nsp) { return } - + p.justAck = true socket.waitingData.append(p) } else if p.type == SocketPacketType.CONNECT { - if p.nsp == "" && socket.nsp != nil { + if p.nsp == "" && socket.nsp != "/" { socket.joinNamespace() - } else if p.nsp != "" && socket.nsp == nil { + } else if p.nsp != "" && socket.nsp == "/" { socket.didConnect() } else { socket.didConnect() @@ -313,25 +229,25 @@ class SocketParser { socket.didForceClose(message: "Got Disconnect") } } - + // Handles binary data class func parseBinaryData(data:NSData, socket:SocketIOClient) { // NSLog(data.base64EncodedStringWithOptions(NSDataBase64EncodingOptions.allZeros)) - + if socket.waitingData.count == 0 { NSLog("Got data when not remaking packet") return } - + let shouldExecute = socket.waitingData[0].addData(data) - + if !shouldExecute { return } - + let packet = socket.waitingData.removeAtIndex(0) packet.fillInPlaceholders() - + if !packet.justAck { socket.handleEvent(packet.getEvent(), data: packet.data, wantsAck: packet.id, withAckType: 6)