cheykrym/socket.io-client-swift
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't set configs after connect

Browse Source
This commit is contained in:
Erik Little 2017-09-30 13:32:44 -04:00
parent 321bb186df
commit 28cc8eef19
No known key found for this signature in database
GPG Key ID: 4930B7C5FBC1A69D
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Source/SocketIO/Client/SocketIOClient.swift
View File

@ -54,18 +54,24 @@ open class SocketIOClient : NSObject, SocketIOClientSpec, SocketEngineClient, So
/// ///
/// **This cannot be set after calling one of the connect methods**. /// **This cannot be set after calling one of the connect methods**.
public var config: SocketIOClientConfiguration { public var config: SocketIOClientConfiguration {
didSet { get {
return _config
}
set {
guard status == .notConnected else { guard status == .notConnected else {
DefaultSocketLogger.Logger.error("Tried setting config after calling connect", DefaultSocketLogger.Logger.error("Tried setting config after calling connect",
type: SocketIOClient.logType) type: SocketIOClient.logType)
return return
} }
_config = newValue
if socketURL.absoluteString.hasPrefix("https://") { if socketURL.absoluteString.hasPrefix("https://") {
config.insert(.secure(true)) _config.insert(.secure(true))
} }
config.insert(.path("/socket.io/"), replacing: false) _config.insert(.path("/socket.io/"), replacing: false)
setConfigs() setConfigs()
} }
} }
@ -130,6 +136,7 @@ open class SocketIOClient : NSObject, SocketIOClientSpec, SocketEngineClient, So
private(set) var currentAck = -1 private(set) var currentAck = -1
private(set) var reconnectAttempts = -1 private(set) var reconnectAttempts = -1
private var _config: SocketIOClientConfiguration
private var currentReconnectAttempt = 0 private var currentReconnectAttempt = 0
private var reconnecting = false private var reconnecting = false
@ -140,14 +147,14 @@ open class SocketIOClient : NSObject, SocketIOClientSpec, SocketEngineClient, So
/// - parameter socketURL: The url of the socket.io server. /// - parameter socketURL: The url of the socket.io server.
/// - parameter config: The config for this socket. /// - parameter config: The config for this socket.
public init(socketURL: URL, config: SocketIOClientConfiguration = []) { public init(socketURL: URL, config: SocketIOClientConfiguration = []) {
self.config = config self._config = config
self.socketURL = socketURL self.socketURL = socketURL
if socketURL.absoluteString.hasPrefix("https://") { if socketURL.absoluteString.hasPrefix("https://") {
self.config.insert(.secure(true)) self._config.insert(.secure(true))
} }
self.config.insert(.path("/socket.io/"), replacing: false) self._config.insert(.path("/socket.io/"), replacing: false)
super.init() super.init()