clean up some things before xcode8 release

This commit is contained in:
Erik 2016-09-10 09:17:50 -04:00
parent fa4346cbc8
commit 31adcd4728
No known key found for this signature in database
GPG Key ID: 4930B7C5FBC1A69D
5 changed files with 21 additions and 21 deletions

View File

@ -340,7 +340,7 @@ public final class SocketEngine : NSObject, URLSessionDelegate, SocketEnginePoll
ws.writeString(msg) ws.writeString(msg)
} }
postWait.removeAll(keepingCapacity: true) postWait.removeAll(keepingCapacity: false)
} }
private func handleClose(_ reason: String) { private func handleClose(_ reason: String) {
@ -364,6 +364,7 @@ public final class SocketEngine : NSObject, URLSessionDelegate, SocketEnginePoll
guard let sid = json["sid"] as? String else { guard let sid = json["sid"] as? String else {
didError(reason: "Open packet contained no sid") didError(reason: "Open packet contained no sid")
return return
} }
@ -435,14 +436,13 @@ public final class SocketEngine : NSObject, URLSessionDelegate, SocketEnginePoll
switch type { switch type {
case .message: case .message:
handleMessage( handleMessage(String(fixedString.characters.dropFirst()))
fixedString[fixedString.characters.index(after: fixedString.characters.startIndex)..<fixedString.endIndex])
case .noop: case .noop:
handleNOOP() handleNOOP()
case .pong: case .pong:
handlePong(with: fixedString) handlePong(with: fixedString)
case .open: case .open:
handleOpen(openData: fixedString[fixedString.characters.index(after: fixedString.characters.startIndex)..<fixedString.endIndex]) handleOpen(openData: String(fixedString.characters.dropFirst()))
case .close: case .close:
handleClose(fixedString) handleClose(fixedString)
default: default:

View File

@ -90,7 +90,9 @@ extension SocketEnginePollable {
} }
public func doPoll() { public func doPoll() {
if websocket || waitingForPoll || !connected || closed { return } if websocket || waitingForPoll || !connected || closed {
return
}
waitingForPoll = true waitingForPoll = true

View File

@ -31,7 +31,7 @@ enum JSONError : Error {
extension Array { extension Array {
func toJSON() throws -> Data { func toJSON() throws -> Data {
return try JSONSerialization.data(withJSONObject: self as NSArray, options: JSONSerialization.WritingOptions(rawValue: 0)) return try JSONSerialization.data(withJSONObject: self, options: JSONSerialization.WritingOptions(rawValue: 0))
} }
} }

View File

@ -257,7 +257,8 @@ public final class SocketIOClient : NSObject, SocketEngineClient, SocketParsable
// If the server wants to know that the client received data // If the server wants to know that the client received data
func emitAck(_ ack: Int, with items: [Any]) { func emitAck(_ ack: Int, with items: [Any]) {
emitQueue.async { emitQueue.async {
if self.status == .connected { guard self.status == .connected else { return }
let packet = SocketPacket.packetFromEmit(items, id: ack, nsp: self.nsp, ack: true) let packet = SocketPacket.packetFromEmit(items, id: ack, nsp: self.nsp, ack: true)
let str = packet.packetString let str = packet.packetString
@ -266,7 +267,6 @@ public final class SocketIOClient : NSObject, SocketEngineClient, SocketParsable
self.engine?.send(str, withData: packet.binary) self.engine?.send(str, withData: packet.binary)
} }
} }
}
public func engineDidClose(reason: String) { public func engineDidClose(reason: String) {
waitingPackets.removeAll() waitingPackets.removeAll()
@ -428,8 +428,7 @@ public final class SocketIOClient : NSObject, SocketEngineClient, SocketParsable
} }
DefaultSocketLogger.Logger.log("Trying to reconnect", type: logType) DefaultSocketLogger.Logger.log("Trying to reconnect", type: logType)
handleEvent("reconnectAttempt", data: [(reconnectAttempts - currentReconnectAttempt)], handleEvent("reconnectAttempt", data: [(reconnectAttempts - currentReconnectAttempt)], isInternalMessage: true)
isInternalMessage: true)
currentReconnectAttempt += 1 currentReconnectAttempt += 1
connect() connect()

View File

@ -40,7 +40,6 @@ struct SocketPacket {
var binary: [Data] var binary: [Data]
var data: [Any] var data: [Any]
var args: [Any] { var args: [Any] {
if type == .event || type == .binaryEvent && data.count != 0 { if type == .event || type == .binaryEvent && data.count != 0 {
return Array(data.dropFirst()) return Array(data.dropFirst())
@ -62,8 +61,8 @@ struct SocketPacket {
return createPacketString() return createPacketString()
} }
init(type: PacketType, data: [Any] = [Any](), id: Int = -1, init(type: PacketType, data: [Any] = [Any](), id: Int = -1, nsp: String, placeholders: Int = 0,
nsp: String, placeholders: Int = 0, binary: [Data] = [Data]()) { binary: [Data] = [Data]()) {
self.data = data self.data = data
self.id = id self.id = id
self.nsp = nsp self.nsp = nsp
@ -112,9 +111,9 @@ struct SocketPacket {
private func createPacketString() -> String { private func createPacketString() -> String {
let typeString = String(type.rawValue) let typeString = String(type.rawValue)
// Binary count? // Binary count?
let binaryCountString = typeString + (type == .binaryEvent || type == .binaryAck ? String(binary.count) + "-" : "") let binaryCountString = typeString + (type == .binaryEvent || type == .binaryAck ? "\(String(binary.count))-" : "")
// Namespace? // Namespace?
let nspString = binaryCountString + (nsp != "/" ? nsp + "," : "") let nspString = binaryCountString + (nsp != "/" ? "\(nsp)," : "")
// Ack number? // Ack number?
let idString = nspString + (id != -1 ? String(id) : "") let idString = nspString + (id != -1 ? String(id) : "")