cheykrym/socket.io-client-swift
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify comments to explain why we did the move

Browse Source
This commit is contained in:
Erik Little 2018-06-07 07:15:43 -04:00
parent f7ccf338ad
commit 5fdff65281
No known key found for this signature in database
GPG Key ID: 62F837E56F4E9320
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/SocketIO/Engine/SocketEngine.swift
View File

@ -359,7 +359,6 @@ open class SocketEngine : NSObject, URLSessionDelegate, SocketEnginePollable, So
/// ///
/// **You shouldn't call this directly** /// **You shouldn't call this directly**
open func doFastUpgrade() { open func doFastUpgrade() {
if waitingForPoll { if waitingForPoll {
DefaultSocketLogger.Logger.error("Outstanding poll when switched to WebSockets," + DefaultSocketLogger.Logger.error("Outstanding poll when switched to WebSockets," +
"we'll probably disconnect soon. You should report this.", type: SocketEngine.logType) "we'll probably disconnect soon. You should report this.", type: SocketEngine.logType)
@ -374,7 +373,8 @@ open class SocketEngine : NSObject, URLSessionDelegate, SocketEnginePollable, So
flushProbeWait() flushProbeWait()
// Need to flush postWait to socket since it connected successfully // Need to flush postWait to socket since it connected successfully
// (moved from flushProbeWait() since it is also called on connected failure) // moved from flushProbeWait() since it is also called on connected failure, and we don't want to try and send
// packets through WebSockets when WebSockets has failed!
if !postWait.isEmpty { if !postWait.isEmpty {
flushWaitingForPostToWebSocket() flushWaitingForPostToWebSocket()
} }

1
Source/SocketIO/Manager/SocketManager.swift
View File

@ -168,7 +168,6 @@ open class SocketManager : NSObject, SocketManagerSpec, SocketParsable, SocketDa
DefaultSocketLogger.Logger.log("Adding engine", type: SocketManager.logType) DefaultSocketLogger.Logger.log("Adding engine", type: SocketManager.logType)
engine?.engineQueue.sync { engine?.engineQueue.sync {
self.engine?.client = nil self.engine?.client = nil
// Close old engine so it will not leak because of URLSession if in polling mode // Close old engine so it will not leak because of URLSession if in polling mode