cheykrym/socket.io-client-swift
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use guard statements in polling

Browse Source
This commit is contained in:
Erik 2017-05-20 16:52:24 -04:00
parent 7cf4d527df
commit 6ca554f4ad
No known key found for this signature in database
GPG Key ID: 4930B7C5FBC1A69D
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Source/SocketEnginePollable.swift
View File

@ -114,9 +114,7 @@ extension SocketEnginePollable {
/// ///
/// You shouldn't need to call this directly, the engine should automatically maintain a long-poll request. /// You shouldn't need to call this directly, the engine should automatically maintain a long-poll request.
public func doPoll() { public func doPoll() {
if websocket || waitingForPoll || !connected || closed { guard !websocket && !waitingForPoll && connected && !closed else { return }
return
}
var req = URLRequest(url: urlPollingWithSid) var req = URLRequest(url: urlPollingWithSid)
addHeaders(to: &req) addHeaders(to: &req)
@ -125,9 +123,7 @@ extension SocketEnginePollable {
} }
func doRequest(for req: URLRequest, callbackWith callback: @escaping (Data?, URLResponse?, Error?) -> Void) { func doRequest(for req: URLRequest, callbackWith callback: @escaping (Data?, URLResponse?, Error?) -> Void) {
if !polling || closed || invalidated || fastUpgrade { guard polling && !closed && !invalidated && !fastUpgrade else { return }
return
}
DefaultSocketLogger.Logger.log("Doing polling %@ %@", type: "SocketEnginePolling", DefaultSocketLogger.Logger.log("Doing polling %@ %@", type: "SocketEnginePolling",
args: req.httpMethod ?? "", req) args: req.httpMethod ?? "", req)
@ -168,10 +164,10 @@ extension SocketEnginePollable {
} }
private func flushWaitingForPost() { private func flushWaitingForPost() {
if postWait.count == 0 || !connected { guard postWait.count != 0 && connected else { return }
return guard !websocket else {
} else if websocket {
flushWaitingForPostToWebSocket() flushWaitingForPostToWebSocket()
return return
} }