cheykrym/socket.io-client-swift
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

check for 200 status code when polling #857

Browse Source
This commit is contained in:
Erik Little 2018-10-02 07:53:36 -04:00
parent 3bf28cd427
commit e877bb26c3
No known key found for this signature in database
GPG Key ID: 62F837E56F4E9320
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Source/SocketIO/Engine/SocketEnginePollable.swift
View File

@ -122,9 +122,12 @@ extension SocketEnginePollable {
doRequest(for: req) {[weak self] data, res, err in doRequest(for: req) {[weak self] data, res, err in
guard let this = self, this.polling else { return } guard let this = self, this.polling else { return }
guard let data = data, let res = res as? HTTPURLResponse, res.statusCode == 200 else {
if err != nil || data == nil { if let err = err {
DefaultSocketLogger.Logger.error(err?.localizedDescription ?? "Error", type: "SocketEnginePolling") DefaultSocketLogger.Logger.error(err.localizedDescription, type: "SocketEnginePolling")
} else {
DefaultSocketLogger.Logger.error("Error during long poll request", type: "SocketEnginePolling")
}
if this.polling { if this.polling {
this.didError(reason: err?.localizedDescription ?? "Error") this.didError(reason: err?.localizedDescription ?? "Error")
@ -135,7 +138,7 @@ extension SocketEnginePollable {
DefaultSocketLogger.Logger.log("Got polling response", type: "SocketEnginePolling") DefaultSocketLogger.Logger.log("Got polling response", type: "SocketEnginePolling")
if let str = String(data: data!, encoding: .utf8) { if let str = String(data: data, encoding: .utf8) {
this.parsePollingMessage(str) this.parsePollingMessage(str)
} }
@ -163,11 +166,14 @@ extension SocketEnginePollable {
DefaultSocketLogger.Logger.log("POSTing", type: "SocketEnginePolling") DefaultSocketLogger.Logger.log("POSTing", type: "SocketEnginePolling")
doRequest(for: req) {[weak self] data, res, err in doRequest(for: req) {[weak self] _, res, err in
guard let this = self else { return } guard let this = self else { return }
guard let res = res as? HTTPURLResponse, res.statusCode == 200 else {
if err != nil { if let err = err {
DefaultSocketLogger.Logger.error(err?.localizedDescription ?? "Error", type: "SocketEnginePolling") DefaultSocketLogger.Logger.error(err.localizedDescription, type: "SocketEnginePolling")
} else {
DefaultSocketLogger.Logger.error("Error flushing waiting posts", type: "SocketEnginePolling")
}
if this.polling { if this.polling {
this.didError(reason: err?.localizedDescription ?? "Error") this.didError(reason: err?.localizedDescription ?? "Error")